[SPC] Add tests for new paymentEntitiesLogos field #53358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
stephenmcgruer
force-pushed
the
smcgruer/spc-payment-entities-logos
branch
from
efbf4d6 to
40e07a9
Compare
|
@pejic - PTAL |
pejic
approved these changes
Jul 23, 2025
rsolomakhin
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See w3c/secure-payment-confirmation#294
Since Chrome only supports this on Chrome Android currently (and only in Canary), this was tested using Chrome for Android 140.0.7313.0, manually disabling testdriver, with the following command lines:
./wpt run --log-mach=- --log-mach-verbose --test-type=testharness --channel=canary --device-serial=SERIAL_HERE --timeout-multiplier=100 --binary-arg="--enable-features=SecurePaymentConfirmationUxRefresh" chrome_android TEST_NAME
Tests validated this way:
secure-payment-confirmation/authentication-accepted.https.htmlsecure-payment-confirmation/authentication-invalid-payment-entity-logo.https.html<-- previously failed, now fixed in https://issues.chromium.org/issues/427695905secure-payment-confirmation/constructor-validate-payment-method-data.https.html