-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GitHub Actions] use Ubuntu 24.04 for all workflows #50649
base: master
Are you sure you want to change the base?
Conversation
Per a GitHub email, Ubuntu 20.04 will be fully unsupported by April 1, 2025 and there are brownout periods starting March 4. Make all workflows use 24.04 instead.
There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you! |
0162a1f
to
e003ec9
Compare
I've dry run everything that I could here. The setup for Safari runs involves multiple workflows and I don't know how to dry run it end-to-end. But check-workflow-run.yml and wpt_fyi_notify.yml both looks fairly simple, as in they don't really depend much on the underlying OS, except for Python being there. @gsnedders would it be OK to land this and monitor the following Safari runs, or are there more things that can be dry run here? |
Per #43361 (comment) there are also .azure-pipelines.yml and fyi_hook.yml. |
@past those are for Azure Pipelines and the email I got was only for GitHub Actions. But I can update the Azure Pipelines images in a separate PR, it's likely Azure Pipelines will also retire 20.04 soonish. |
Right, I assume that they all use the same data center infra under the hood. |
Everything being run on Ubuntu is very boring, and I'd be very surprised if it broke; I'd just change it. (I did debate doing this a while back, but it seemed like unnecessary risk given many of these only run on schedules.) |
At least a few years ago it was clear that at least macOS agents were separate pools. But it would make a lot of sense if Azure Pipelines and GitHub Actions converge, if they haven't fully already. I'll send that other PR. |
These jobs could probably run on any OS, but upgrade to stay in sync with GitHub Actions and avoid breakage if 20.04 is turned down: #50649
Per a GitHub email, Ubuntu 20.04 will be fully unsupported by April 1,
2025 and there are brownout periods starting March 4.
Make all workflows use 24.04 instead.
Fixes #43361.
Checklist to confirm still working before landing this: