Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] use Ubuntu 24.04 for all workflows #50649

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 12, 2025

Per a GitHub email, Ubuntu 20.04 will be fully unsupported by April 1,
2025 and there are brownout periods starting March 4.

Make all workflows use 24.04 instead.
Fixes #43361.


Checklist to confirm still working before landing this:

Per a GitHub email, Ubuntu 20.04 will be fully unsupported by April 1,
2025 and there are brownout periods starting March 4.

Make all workflows use 24.04 instead.
@foolip foolip requested review from jgraham and gsnedders and removed request for jgraham February 12, 2025 08:31
@wpt-pr-bot wpt-pr-bot requested a review from past February 12, 2025 08:31
@foolip foolip requested review from jgraham and removed request for past February 12, 2025 08:32
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you!

@foolip foolip force-pushed the ubuntu-24.04 branch 2 times, most recently from 0162a1f to e003ec9 Compare February 12, 2025 11:14
@foolip
Copy link
Member Author

foolip commented Feb 12, 2025

I've dry run everything that I could here. The setup for Safari runs involves multiple workflows and I don't know how to dry run it end-to-end. But check-workflow-run.yml and wpt_fyi_notify.yml both looks fairly simple, as in they don't really depend much on the underlying OS, except for Python being there.

@gsnedders would it be OK to land this and monitor the following Safari runs, or are there more things that can be dry run here?

@past
Copy link
Member

past commented Feb 12, 2025

Per #43361 (comment) there are also .azure-pipelines.yml and fyi_hook.yml.

@foolip
Copy link
Member Author

foolip commented Feb 12, 2025

@past those are for Azure Pipelines and the email I got was only for GitHub Actions. But I can update the Azure Pipelines images in a separate PR, it's likely Azure Pipelines will also retire 20.04 soonish.

@past
Copy link
Member

past commented Feb 12, 2025

Right, I assume that they all use the same data center infra under the hood.

@gsnedders
Copy link
Member

I've dry run everything that I could here. The setup for Safari runs involves multiple workflows and I don't know how to dry run it end-to-end. But check-workflow-run.yml and wpt_fyi_notify.yml both looks fairly simple, as in they don't really depend much on the underlying OS, except for Python being there.

@gsnedders would it be OK to land this and monitor the following Safari runs, or are there more things that can be dry run here?

Everything being run on Ubuntu is very boring, and I'd be very surprised if it broke; I'd just change it.

(I did debate doing this a while back, but it seemed like unnecessary risk given many of these only run on schedules.)

@foolip
Copy link
Member Author

foolip commented Feb 13, 2025

Right, I assume that they all use the same data center infra under the hood.

At least a few years ago it was clear that at least macOS agents were separate pools. But it would make a lot of sense if Azure Pipelines and GitHub Actions converge, if they haven't fully already.

I'll send that other PR.

foolip added a commit that referenced this pull request Feb 13, 2025
These jobs could probably run on any OS, but upgrade to stay in sync
with GitHub Actions and avoid breakage if 20.04 is turned down:
#50649
@foolip
Copy link
Member Author

foolip commented Feb 13, 2025

#50676

@mukilan
Copy link
Contributor

mukilan commented Feb 24, 2025

@foolip The PR description says this fixes #43361, but I don't see the Dockerfile being updated in this PR. Just wanted to confirm if that is planned work for a separate PR or if it was just missed in this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade wpt docker image to Ubuntu 22.04
5 participants