Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
43184ee
Acc test for input with acc name coming from label elements with role…
giacomo-petri Jan 9, 2025
8fdb651
Update comp_host_language_label.tentative.html
giacomo-petri Jan 9, 2025
28d3673
Update comp_host_language_label.tentative.html
giacomo-petri Jan 11, 2025
0af612d
Create role_none_conflict_resolution.tentative.html
giacomo-petri Jan 11, 2025
84dddad
Update comp_host_language_label.tentative.html
giacomo-petri Jan 13, 2025
828fd3c
Update role_none_conflict_resolution.tentative.html
giacomo-petri Jan 13, 2025
ba51332
Update comp_host_language_label.tentative.html
giacomo-petri Jan 15, 2025
6dff699
Update role_none_conflict_resolution.tentative.html
giacomo-petri Jan 15, 2025
03eb59d
Apply suggestions from code review
giacomo-petri Jan 17, 2025
ff3b093
Apply suggestions from code review
giacomo-petri Jan 17, 2025
a2cb698
Update role_none_conflict_resolution.tentative.html
giacomo-petri Jan 17, 2025
46f594d
Update comp_host_language_label.tentative.html
giacomo-petri Jan 17, 2025
ba37e50
Update comp_host_language_label.tentative.html
giacomo-petri Jan 17, 2025
3fa7dda
Update role_none_conflict_resolution.tentative.html
giacomo-petri Jan 17, 2025
c03918e
Update comp_host_language_label.tentative.html
giacomo-petri Jan 17, 2025
87d1daf
Update comp_host_language_label.tentative.html
giacomo-petri Jan 17, 2025
ca57c8f
Update comp_host_language_label.tentative.html
giacomo-petri Jan 21, 2025
9ee3cf6
updated all data-testname with valid CSS selectors and added expectat…
giacomo-petri Jan 31, 2025
d00b88f
removed elements with computed role of none
giacomo-petri Jan 31, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comp_host_language_label.tentative.html
replaced role none with role=none
  • Loading branch information
giacomo-petri authored Jan 17, 2025
commit 46f594d6c7f364d1dd2260c84cd84cce76fc1eb5
30 changes: 15 additions & 15 deletions accname/name/comp_host_language_label.tentative.html
Original file line number Diff line number Diff line change
@@ -18,66 +18,66 @@ <h3>HTML input label/for</h3>
<h3>HTML label encapsulation</h3>
<label role="none">
<span>input label</span>
<input type="text" data-expectedlabel="input label" data-testname="html: label[role none] encapsulation" class="ex-label">
<input type="text" data-expectedlabel="input label" data-testname="html: label[role=none] encapsulation" class="ex-label">
</label>

<h2>HTML input with role="none" and label associated (presentational roles conflict resolution)</h2>
<h3>HTML input label/for</h3>
<label for="irn">input label</label>
<input id="irn" type="text" data-expectedlabel="input label" data-testname="html: label[for]input[role none]" class="ex-label" role="none">
<input id="irn" type="text" data-expectedlabel="input label" data-testname="html: label[for]input[role=none]" class="ex-label" role="none">
<h3>HTML label encapsulation</h3>
<label>
<span>input label</span>
<input type="text" data-expectedlabel="input label" data-testname="html: input[role none] with label encapsulation" class="ex-label" role="none">
<input type="text" data-expectedlabel="input label" data-testname="html: input[role=none] with label encapsulation" class="ex-label" role="none">
</label>

<h2>HTML input with role="none" and label with role none (presentational roles conflict resolution)</h2>
<h3>HTML input label/for</h3>
<label role="none" for="lirp">input label</label>
<input id="lirp" type="text" data-expectedlabel="input label" data-testname="html: label[for][role none] input[role none]" class="ex-label" role="none">
<input id="lirp" type="text" data-expectedlabel="input label" data-testname="html: label[for][role=none] input[role=none]" class="ex-label" role="none">
<h3>HTML label encapsulation</h3>
<label role="none">
<span>input label</span>
<input type="text" data-expectedlabel="input label" data-testname="html: input[role none] with label[role none] encapsulation" class="ex-label" role="none">
<input type="text" data-expectedlabel="input label" data-testname="html: input[role=none] with label[role=none] encapsulation" class="ex-label" role="none">
</label>

<h2>HTML input with role="none" and disabled with label associated</h2>
<h3>HTML input label/for</h3>
<label for="irpd">input label</label>
<input id="irpd" type="text" data-expectedlabel="" data-testname="html: label[for]input[role none][disabled]" class="ex-label" role="none" disabled>
<input id="irpd" type="text" data-expectedlabel="" data-testname="html: label[for]input[role=none][disabled]" class="ex-label" role="none" disabled>
<h3>HTML label encapsulation</h3>
<label>
<span>input label</span>
<input type="text" data-expectedlabel="" data-testname="html: input[role none][disabled] with label encapsulation" class="ex-label" role="none" disabled>
<input type="text" data-expectedlabel="" data-testname="html: input[role=none][disabled] with label encapsulation" class="ex-label" role="none" disabled>
</label>

<h2>HTML img with role="none" and non empty alt</h2>
<img src="https://www.w3.org/assets/logos/w3c/w3c-no-bars.svg" role="none" alt="w3c logo" data-expectedlabel="" data-testname="html: img[role none][non-empty alt]" class="ex-label">
<img src="https://www.w3.org/assets/logos/w3c/w3c-no-bars.svg" role="none" alt="w3c logo" data-expectedlabel="" data-testname="html: img[role=none][non-empty alt]" class="ex-label">

<h2>SVG wrapping title with role="none"</h2>
<svg viewBox="0 0 20 10" xmlns="http://www.w3.org/2000/svg" data-expectedlabel="circle" data-testname="svg: svg wrapping title[role none]" class="ex-label">
<svg viewBox="0 0 20 10" xmlns="http://www.w3.org/2000/svg" data-expectedlabel="circle" data-testname="svg: svg wrapping title[role=none]" class="ex-label">
<circle cx="5" cy="5" r="4">
<title role="none">circle</title>
</circle>
</svg>

<h2>HTML fieldset wrapping legend with role="none"</h2>
<fieldset data-expectedlabel="legend" data-testname="html: fieldset wrapping legend[role none]" class="ex-label"><legend role="none">legend</legend></fieldset>
<fieldset data-expectedlabel="legend" data-testname="html: fieldset wrapping legend[role=none]" class="ex-label"><legend role="none">legend</legend></fieldset>

<h2>HTML fieldset with role="none" wrapping legend</h2>
<fieldset role="none" data-expectedlabel="" data-testname="html: fieldset[role none] wrapping legend" class="ex-label"><legend>legend</legend></fieldset>
<fieldset role="none" data-expectedlabel="" data-testname="html: fieldset[role=none] wrapping legend" class="ex-label"><legend>legend</legend></fieldset>

<h2>HTML fieldset role="none" wrapping legend with role="none"</h2>
<fieldset role="none" data-expectedlabel="" data-testname="html: fieldset[role none] wrapping legend[role none]" class="ex-label"><legend role="none">legend</legend></fieldset>
<fieldset role="none" data-expectedlabel="" data-testname="html: fieldset[role=none] wrapping legend[role=none]" class="ex-label"><legend role="none">legend</legend></fieldset>

<h2>HTML table wrapping caption with role="none"</h2>
<table data-expectedlabel="caption" data-testname="html: table wrapping caption[role none]" class="ex-label"><caption role="none">caption</caption></table>
<table data-expectedlabel="caption" data-testname="html: table wrapping caption[role=none]" class="ex-label"><caption role="none">caption</caption></table>

<h2>HTML table with role="none" wrapping caption</h2>
<table role="none" data-expectedlabel="" data-testname="html: table[role none] wrapping caption" class="ex-label"><caption>caption</caption></table>
<table role="none" data-expectedlabel="" data-testname="html: table[role=none] wrapping caption" class="ex-label"><caption>caption</caption></table>

<h2>HTML table role="none" wrapping caption with role="none"</h2>
<table role="none" data-expectedlabel="" data-testname="html: table[role none] wrapping caption[role none]" class="ex-label"><caption role="none">caption</caption></table>
<table role="none" data-expectedlabel="" data-testname="html: table[role=none] wrapping caption[role=none]" class="ex-label"><caption role="none">caption</caption></table>

<script>
AriaUtils.verifyLabelsBySelector(".ex-label");