Improve idlharness-ShadowRealm integration #49342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
domfarolino,
foolip,
igrigorik,
inexorabletash,
jdm,
jgraham,
mikewest,
Ms2ger,
plehegar and
pwnall
Ms2ger
reviewed
Nov 25, 2024
By exposing a fetch_spec() on globalThis in testharness-shadowrealm-inner, we no longer need to have IDL tests in separate files for ShadowRealm, as the regular idlharness.js will just run there. Delete all existing idlharness-shadowrealm.window.js files and incorporate them into their neighbouring idlharness.any.js files. It seems sufficient to run the IDL tests only in shadowrealm-in-window; repeating them in every ShadowRealm scope seems like overkill.
This gets me every time. If we are testing that an interface is not exposed, we should be clear about that in the test message.
Instead, if a namespace is not exposed, test that there is no global property of that name, similar to what we do with interfaces.
ptomato
force-pushed
the
improve-idlharness-shadowrealm-integration
branch
from
529810f to
f47170b
Compare
wpt-pr-bot
requested review from
wanderview,
youennf,
yuki3 and
yutakahirano
inexorabletash
approved these changes
Nov 25, 2024
Ms2ger
approved these changes
Nov 26, 2024
5 tasks
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defining
globalThis.fetch_spec()intestharness-shadowrealm-inner.js, we no longer need to have IDL tests in separate files for ShadowRealm, as the regularidlharness.jswill now just run there.This allows consolidating the
idlharness-shadowrealm.window.jstests back into their neighbouringidlharness.any.jsfiles.