[wdspec] doc adding new WebDriver BiDi modules #49070
Conversation
sadym-chromium
changed the title
sadym-chromium
requested review from
OrKoN and
jcscottiii
and removed request for
sideshowbarker
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
docs/writing-tests/wdspec.md
Outdated
| ##### Create `BidiModule` | ||
|
|
||
| BiDi modules are defined in the `tools/webdriver/webdriver/bidi/modules/` directory. | ||
| To add a new module called `bluetooth`, declare a Python class |
There was a problem hiding this comment.
I would quite strongly prefer the examples here to be something that has multi-vendor support.
There was a problem hiding this comment.
I would agree here. The Permissions API can be used instead for such an example. It's one which has cross-browser support.
There was a problem hiding this comment.
I am not sure this guide requires a specific module as an example, I would be happy with a foo module using a bar command but permissions sounds good to me too.
There was a problem hiding this comment.
Switched to Permissions, as it allows to provide a specific code snippets comparing to an abstract foo.
There was a problem hiding this comment.
@jgraham was it the only blocker for this doc?
docs/writing-tests/wdspec.md
Outdated
| ##### Create `BidiModule` | ||
|
|
||
| BiDi modules are defined in the `tools/webdriver/webdriver/bidi/modules/` directory. | ||
| To add a new module called `bluetooth`, declare a Python class |
There was a problem hiding this comment.
I would agree here. The Permissions API can be used instead for such an example. It's one which has cross-browser support.
sadym-chromium
force-pushed
the
sadym/bidi-doc
branch
from
cf54df1 to
aba8477
Compare
sadym-chromium
changed the title
Co-authored-by: jgraham <[email protected]>
Explain adding WebDriver BiDi modules in example of Permissions.