Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregatable debug reporting routes to RoutesBuilder #46569

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

linnan-github
Copy link
Contributor

Attribution Reporting API supports collecting aggregatable debug reports. Adding aggregatable debug reports routes as a well-known route to the RoutesBuilder so that the WPT server can receive and return debug reports.

Explainer: https://github.com/WICG/attribution-reporting-api/blob/main/aggregate_debug_reporting.md

@linnan-github
Copy link
Contributor Author

@foolip Friendly ping, could you PTAL, thanks!

@linnan-github
Copy link
Contributor Author

@foolip Thanks for reviewing. I don't have write access to the repository, could you help merge it? Thanks.

@foolip
Copy link
Member

foolip commented Jun 4, 2024

@linnan-github there are CI failures that I don't understand but I suspect they're unrelated to your changes.

@past I have my old #28759 that I rebase in situations like this, but is there any other way we have to detect when tests are broken on master? Is keeping it working part of any rotation currently?

@linnan-github
Copy link
Contributor Author

@linnan-github there are CI failures that I don't understand but I suspect they're unrelated to your changes.

@past I have my old #28759 that I rebase in situations like this, but is there any other way we have to detect when tests are broken on master? Is keeping it working part of any rotation currently?

Thanks @foolip. Would really appreciate it if you could help with the merge fix.

@past
Copy link
Member

past commented Jun 4, 2024

I think the failures are unrelated. Some are clearly transient connection issues (e.g. the infrastructure/ tests), others are known (like tools/ unit tests, which we hope #46383 will fix). I'll admin merge this.

@past past merged commit 3b3d9cb into web-platform-tests:master Jun 4, 2024
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants