-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify WebVTT snap-to-line test by avoiding cue alignment settings #46455
base: master
Are you sure you want to change the base?
Conversation
The test passes in Firefox before and after these changes. The rendering isn't affected because these settings are the defaults.
Is there another check for the passing of these settings? |
@silviapfeiffer you can see the before/after for Firefox here: And these are the after results for Chrome+Firefox+Safari, Chrome+Safari still failing: |
A bit of context for this is that I was working on mapping the tests to the features in https://webstatus.dev/?q=webvtt and web-platform-dx/web-features#1121 which I'm adding. Looking for rendering tests for cue alignment settings I could only find this one, but it's not really a test for that. In the end, mapping the tests to features is easier if all of the tests in this directory are for the base WebVTT feature. |
Thanks for that clarification. Great to see you are adding specific tests for the line-left and start settings and will be testing these separately. Given this addition of tests, I'm fine with this change. |
@silviapfeiffer to make sure there's no miscommunication, web-platform-dx/web-features#1121 is adding the feature to web-features, and I will find the tests for cue alignment settings in WPT so that they can be shown on wpt.fyi using Without rendering tests the feature isn't really tested well enough. I can file an issue about this, but am not planning to improve the test coverage myself. |
At minimum, this test was testing the parsing of that feature, even if it didn't do a rendering test. |
The test passes in Firefox before and after these changes. The rendering
isn't affected because these settings are the defaults.