Chrome Canary and Chromium Nightly are installed via --install-browser in Taskcluster
#44275
Conversation
| args = ["--enable-swiftshader"] | ||
| # Chrome Stable-Dev are still installed in tools/ci/run_tc.py | ||
| if channel == "nightly" or channel == "canary": | ||
| args.extend(["--install-browser", "--install-webdriver"]) |
There was a problem hiding this comment.
Wait, don't we need --install-webdriver for Stable-Dev? And for CfT, we shouldn't need it, because we get it from the same package?
There was a problem hiding this comment.
ChromeDriver is still always a separate download, although we maintain the download url to match exactly the browser binary version downloaded.
To be honest, I'm not certain, but if I had to guess, I would assume that the default behavior is to prompt webdriver installation if a webdriver is not found. So that means --install-webdriver is implicit as long as there is no other found webdriver, and as long as we're passing the --yes flag, it will just accept that installation.
There was a problem hiding this comment.
I just checked this locally, after clearing my browser/webdriver binaries, using ./wpt run --install-browser --channel dev chrome dom/historical.html. I was indeed prompted to install a matching webdriver, so it seems like this is the reason it works. 🙂
There was a problem hiding this comment.
Hmm, so it sound like things work, but maybe we're double downloading the chromedriver binary in the CfT case. Can you file an issue if you think that's the case? Then feel free to land this.
|
Closing this PR since this was planned to be a temporary fix. |
This change specifies that only Chrome Canary and Chromium Nightly are installed via the
--install-browsercommand. Some test results on Chrome Dev have become flaky since changing this last week, and this update will rectify the issue while the root cause is identified.