Remove use of six.ensure_str/ensure_text in wptrunner #28935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I intend to leave this until #28942 is done, to be able to type check the results a bit. |
foolip
force-pushed
the
foolip/six_wptrunner
branch
from
0e323f8 to
1b0b650
Compare
foolip
commented
Sep 10, 2021
foolip
force-pushed
the
foolip/six_wptrunner
branch
2 times, most recently
from
2afcaa3 to
90af724
Compare
foolip
force-pushed
the
foolip/six_wptrunner
branch
from
90af724 to
087c8ac
Compare
|
@gsnedders @jgraham these are our last direct uses of six. I had a hard time convincing myself that the type was guaranteed to be |
|
Ping @gsnedders and @jgraham. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28776.