Fix setting os.environ["PATH"] to a binary string #28849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code would raise "TypeError: str expected, not bytes" is run using Python 3, since setting os.environ keys implictly encodes using sys.getfilesystemencoding(): https://docs.python.org/3/library/os.html#os.environ This might be dead code, or simply not exercised in wpt's CI. Spotted while preparing #28848.
wpt-pr-bot
added
infra
wptrunner
jgraham
approved these changes
May 7, 2021
|
@jgraham I'm going to guess that this code doesn't run on Gecko CI either, unless maybe it's running as Python 2. Run as Python 3 it should throw an error... Let me know and revert quickly if this break Gecko :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code would raise "TypeError: str expected, not bytes" is run using
Python 3, since setting os.environ keys implictly encodes using
sys.getfilesystemencoding():
https://docs.python.org/3/library/os.html#os.environ
This might be dead code, or simply not exercised in wpt's CI.
Spotted while preparing #28848.