Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-lists] test <div> and <span><div> in list item #26715

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

foolip
Copy link
Member

@foolip foolip commented Dec 2, 2020

This is to test the behavior exposed in this webcompat.com issue:
webcompat/web-bugs#62451.

This is to test the behavior exposed in this webcompat.com issue:
webcompat/web-bugs#62451.
@foolip
Copy link
Member Author

foolip commented Dec 2, 2020

@emilio can you tell which spec governs this?

@emilio
Copy link
Contributor

emilio commented Dec 2, 2020

So, fwiw, I said that Gecko's behavior seemed "reasonable", not "correct", necessarily.

This is a bit more subtle than it seems. If only because Firefox's behavior matches Chrome/WebKit's in quirks mode.

The <span><div> case basically behaves as if it was <span></span><div></div>.

That creates two line boxes. Now the issue is whether in presence of an outside marker the first line should be "empty" or not (and thus whether it should take space).

So I guess this is basically w3c/csswg-drafts#4574, which is still not super-greatly defined.

@emilio
Copy link
Contributor

emilio commented Dec 2, 2020

I just checked if the quirk that makes this work in quirks mode in Firefox is bullet/list specific and it's not, fwiw: https://searchfox.org/mozilla-central/rev/0d6e8b21569f93a1e1ae8e377ab10f43a6cb12c1/layout/generic/nsLineLayout.cpp#1813

@foolip
Copy link
Member Author

foolip commented Dec 2, 2020

https://wpt.fyi/results/css/css-lists?label=pr_head&max-count=1&pr=26715 shows that at least I achieved what I tried to, showing that there is in fact a difference here.

Since this came from a real web compat issue, one where the result was a broken layout for Firefox users, it would be great to get to the bottom of this, but I don't know this area more than superficially.

@emilio are there people you know we should ping for this?

@foolip
Copy link
Member Author

foolip commented Dec 2, 2020

Oh, and the lint is failing because I don't have a spec link. That's true :)

@foolip
Copy link
Member Author

foolip commented Mar 22, 2023

@emilio do you think it would make sense to make this a tentative test with reference to w3c/csswg-drafts#4574?

@emilio
Copy link
Contributor

emilio commented Mar 22, 2023

Seems reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants