-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-lists] test <div> and <span><div> in list item #26715
base: master
Are you sure you want to change the base?
[css-lists] test <div> and <span><div> in list item #26715
Conversation
This is to test the behavior exposed in this webcompat.com issue: webcompat/web-bugs#62451.
@emilio can you tell which spec governs this? |
So, fwiw, I said that Gecko's behavior seemed "reasonable", not "correct", necessarily. This is a bit more subtle than it seems. If only because Firefox's behavior matches Chrome/WebKit's in quirks mode. The That creates two line boxes. Now the issue is whether in presence of an outside marker the first line should be "empty" or not (and thus whether it should take space). So I guess this is basically w3c/csswg-drafts#4574, which is still not super-greatly defined. |
I just checked if the quirk that makes this work in quirks mode in Firefox is bullet/list specific and it's not, fwiw: https://searchfox.org/mozilla-central/rev/0d6e8b21569f93a1e1ae8e377ab10f43a6cb12c1/layout/generic/nsLineLayout.cpp#1813 |
https://wpt.fyi/results/css/css-lists?label=pr_head&max-count=1&pr=26715 shows that at least I achieved what I tried to, showing that there is in fact a difference here. Since this came from a real web compat issue, one where the result was a broken layout for Firefox users, it would be great to get to the bottom of this, but I don't know this area more than superficially. @emilio are there people you know we should ping for this? |
Oh, and the lint is failing because I don't have a spec link. That's true :) |
@emilio do you think it would make sense to make this a tentative test with reference to w3c/csswg-drafts#4574? |
Seems reasonable |
This is to test the behavior exposed in this webcompat.com issue:
webcompat/web-bugs#62451.