Adjusting //cookie/http-state tests name0031 and name0032. #22559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 31, 2020
19 tasks
Chrome and Firefox aligned on treating `"foo;bar"=baz` as a nameless cookie with a value of `"foo`, and `"foo\"bar;baz"=qux` as a nameless cookie with a value of `"foo\"bar`. That is, they both stop parsing the name/value pair when they hit a `;`. This seems aligned with step 1 of https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-05#section-5.3, which defines the `name-value-pair` as everything up to but not including the first `;`. Adjusting these tests accordingly, as discussed in httpwg/http-extensions#1136. Change-Id: I6930f8e18a8c573b21eaea5614e14c3b957ea0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128135 Reviewed-by: Lily Chen <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/master@{#755255}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2128135
branch
from
35eb537 to
b931663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome and Firefox aligned on treating
"foo;bar"=bazas a nameless cookiewith a value of
"foo, and"foo\"bar;baz"=quxas a nameless cookie witha value of
"foo\"bar. That is, they both stop parsing the name/value pairwhen they hit a
;. This seems aligned with step 1 ofhttps://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-05#section-5.3,
which defines the
name-value-pairas everything up to but not includingthe first
;.Adjusting these tests accordingly, as discussed in
httpwg/http-extensions#1136.
Change-Id: I6930f8e18a8c573b21eaea5614e14c3b957ea0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128135
Reviewed-by: Lily Chen <[email protected]>
Commit-Queue: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#755255}