webrtc: add third-party sdp module #22557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the third-party sdp module available from https://www.npmjs.com/package/sdp in version 2.12.0 and commit 958f22a94231e4c1ca651b4a7d53b0e32bb4a558 without tests or dependencies. This is going to be used by simulcast tests and is generally useful in manipulating the SDP generated and consumed by WebRTC. See web-platform-tests/rfcs#46 for discussion on how to add third-party javascript libraries.
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
guidou,
henbos,
jan-ivar,
rwaldron,
snuggs and
youennf
|
Can you take the text from the PR description and put it into a README.wpt file, so that people looking at this afterwards can figure out where it came from? |
jan-ivar
reviewed
Mar 31, 2020
jan-ivar
approved these changes
Mar 31, 2020
|
went for .md, didn't specify the version or commit hash since that is already part of the commit and having two would be duplicating things which would get out of sync. |
alvestrand
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the third-party sdp module available from
https://www.npmjs.com/package/sdp
in version 2.12.0 and commit
958f22a94231e4c1ca651b4a7d53b0e32bb4a558
without tests or dependencies. This is going to be used by simulcast
tests and is generally useful in manipulating the SDP generated and
consumed by WebRTC.
See web-platform-tests/rfcs#46 for discussion
on how to add third-party javascript libraries.