Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wpt docker image to Ubuntu 22.04 #43361

Open
mukilan opened this issue Nov 27, 2023 · 6 comments · May be fixed by #50649
Open

Upgrade wpt docker image to Ubuntu 22.04 #43361

mukilan opened this issue Nov 27, 2023 · 6 comments · May be fixed by #50649

Comments

@mukilan
Copy link
Contributor

mukilan commented Nov 27, 2023

Servo recently switched to Ubuntu 22.04 for the nightly builds, which meant that binary links against glibc 2.34. This has broken the taskcluster runs for wpt.fyi because wpt uses Ubuntu 20.04 which has glibc 2.31.

As a workaround Servo will switch back to Ubuntu 20.04, but I'm creating this issue to see if WPT docker images can be upgrade dto Ubuntu. Based on the discussion in Matrix with @jgraham, it seems we first want to test the breakage by publishing a new docker image based on 22.04.

@clopez
Copy link
Contributor

clopez commented May 9, 2024

On WebKitGTK we are EOL-ing Ubuntu 20.04 so we will like to start using Ubuntu 22.04 as baseline to provide the built products at https://webkitgtk.org/built-products/x86_64/release/nightly/

@clopez
Copy link
Contributor

clopez commented Sep 12, 2024

Can we just skip 22.04 and upgrade to Ubuntu-24.04 ?

@jgraham
Copy link
Contributor

jgraham commented Sep 20, 2024

I'd certainly be open to a PR trying 24.04. I think Wayland-by-default might cause some issues?

@clopez
Copy link
Contributor

clopez commented Oct 18, 2024

My experience with wayland running on headless servers (no GPU) is that it doesn't work very well with accelerated/opengl content. On the build.webkit.org webkitgtk bots we still run the tests under xvfb due to that, we tested wayland but it was regressing the accelerated/opengl layout tests when the system didn't had a GPU (headless).

But it has been a while (years) since I tried that, perhaps new versions of Weston or other Wayland compositors have improved the status quo.

In any case I would suggest doing this in two steps to be able to blame regressions on either the update of the system, or on the update of the display server.

So first step: update the base system and check for regressions. Then second step: switch to wayland and check for regressions.

Anyway, we are switching the webkitgtk_minibrowser bundles to use an universal bundle with all the required system libraries inside that in theory should work on any distro so we would not longer depend on which version of Ubuntu or any other distro is used on the test container. See: #48698

@past
Copy link
Member

past commented Feb 11, 2025

This is becoming more urgent due to actions/runner-images#11101.

@past
Copy link
Member

past commented Feb 11, 2025

$ grep -r ubuntu-20.04 .
./wpt/.github/workflows/documentation.yml:    runs-on: ubuntu-20.04
./wpt/.github/workflows/interfaces.yml:    runs-on: ubuntu-20.04
./wpt/.github/workflows/manifest.yml:    runs-on: ubuntu-20.04
./wpt/.github/workflows/regen_certs.yml:    runs-on: ubuntu-20.04
./wpt/.github/workflows/epochs.yml:    runs-on: ubuntu-20.04
./wpt/tools/ci/azure/fyi_hook.yml:    vmImage: 'ubuntu-20.04'
./wpt/tools/third_party/websockets/.readthedocs.yml:  os: ubuntu-20.04
./wpt/tools/third_party/pytest/.readthedocs.yml:  os: ubuntu-20.04
./wpt/.azure-pipelines.yml:    vmImage: 'ubuntu-20.04'

@past past linked a pull request Feb 12, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants