-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/wpt tests failing on Python 3.12.8 #49545
Comments
tools/ integration tests (Python 3.12)
consistently failing with ""tools/ integration tests (Python 3.12)
consistently failing with "... is not in the subpath of ..."
https://community-tc.services.mozilla.com/tasks/IaWJRR5pQ0OLBXsD4dL_jw/runs/0/logs/public/logs/live.log is one of the last successful runs,
So it's not even like tox or one of its dependencies changed version. The former was based on master 4817834, the latter based on 1d55057, and there are no changes in We did however change Python version: Selecting previously unselected package python3.12.
-Preparing to unpack .../python3.12_3.12.7-1+focal1_amd64.deb ...
-Unpacking python3.12 (3.12.7-1+focal1) ...
+Preparing to unpack .../python3.12_3.12.8-1+focal1_amd64.deb ...
+Unpacking python3.12 (3.12.8-1+focal1) ... Which thus makes that the most suspicious part; see https://docs.python.org/release/3.12.8/whatsnew/changelog.html#python-3-12-8-final for the full changelog. My first guess is:
In which case it is likely our self-activating virtualenv script at fault. |
(I don't actually have time to particularly investigate this further right now, but I strongly suspect it's that test environment configuration change. This is what we get for non-reproducible environments. 😐) |
Hit this again in #49605. Also when I tried to rerun this task by clicking
This forces us to use close and reopen which will rerun all the tasks. |
Apparently not easily fixable: #39458 |
tools/ integration tests (Python 3.12)
consistently failing with "... is not in the subpath of ..."Instead of having our own copies of what we believe paths should be, or manually mutating what sysconfig returns for other variables, we should just delegate all of this to sysconfig in the standard way. This fixes web-platform-tests#49545, fixing Python 3.12.8 support, where sysconfig stopped overly caching certain variables, thus leading to oddities after we've rewritten sys.exec_prefix and sys.prefix.
Instead of having our own copies of what we believe paths should be, or manually mutating what sysconfig returns for other variables, we should just delegate all of this to sysconfig in the standard way. This fixes #49545, fixing Python 3.12.8 support, where sysconfig stopped overly caching certain variables, thus leading to oddities after we've rewritten sys.exec_prefix and sys.prefix.
Examples across several PRs:
Sample failure:
The theory in the WPT matrix chat is nested virtualenvs, but it doesn't look like the recent commit log for
tools/
contains any likely culprits.The text was updated successfully, but these errors were encountered: