[wptrunner] Decouple testdriver infrastructure from testharness #49044
+229
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-refactor
branch
from
fcfd0c8 to
0f2c1f4
Compare
wpt-pr-bot
added
infra
wptrunner
WeizhongX
reviewed
Nov 10, 2024
WeizhongX
reviewed
Nov 10, 2024
WeizhongX
reviewed
Nov 10, 2024
WeizhongX
reviewed
Nov 11, 2024
WeizhongX
approved these changes
Nov 11, 2024
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-refactor
branch
from
8e59e23 to
8469799
Compare
WeizhongX
approved these changes
Nov 11, 2024
This no-op refactor will allow other WebDriver executors, not just the testharness executor, to perform testdriver actions.
This will allow non-testharness tests to use `testdriver.js` without needing extra scripts. Evaluating `message-queue.js` is idempotent so that, when using testharness with testdriver, the second inclusion is a no-op. Because resource scripts are cached, the size increase should not meaningfully affect test performance.
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-refactor
branch
from
8469799 to
a2ce584
Compare
|
@KyleJu @DanielRyanSmith Force merge due to unrelated failure #49545? If possible, please use the rebase method, not squash, since each commit works standalone. The changes in this PR are primarily covered by the |
KyleJu
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #48486 in preparation for #13183. This PR itself should be a no-op, so it need not block on web-platform-tests/rfcs#211.