Skip to content

Commit

Permalink
Deflake wpt/fledge/tentative/server-response.https.window.html
Browse files Browse the repository at this point in the history
... in the "fails because test keys are not configured case".
It looks like one of the real-life keys got a short ID of 0x12,
so the "key ID isn't what the test configures" failed about a fifth
of the time... so change around the test ID to avoid it.

Bug: 383379786,383413865,383403583,383401572,383399676
Bug: 383397963,383387527,383395709,383393294,383391660
Bug: 383383789,383377137,383374957,383367270,383381981
Bug: 383379241,383372392
Change-Id: Ic27b16de689d9c94a24b65b1e5be19e1ff839afa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088048
Commit-Queue: Maks Orlovich <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1395006}
  • Loading branch information
Maks Orlovich authored and chromium-wpt-export-bot committed Dec 11, 2024
1 parent 6b14d42 commit 82464df
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions fledge/tentative/resources/ba-fledge-util.sub.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,11 @@ BA.decodeInterestGroupData = async function(igData) {
// Only version 0 in use now.
assert_equals(header.version, 0);

// Test config uses keyId = 0x12 only
// Test config uses keyId = 0x14 only
// If the feature is not set up properly we may get a different, non-test key.
// We can't use assert_equals because it includes the (random) non-test key
// in the error message if testing support for this feature is not present.
assert_true(header.keyId === 0x12, "valid key Id");
assert_true(header.keyId === 0x14, "valid key Id");

// Current cipher config.
assert_equals(header.kemId, hpke.KemId.DhkemX25519HkdfSha256);
Expand Down
2 changes: 1 addition & 1 deletion fledge/tentative/resources/ba-public-keys
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"keys":[{"id":"12345678-9abc-def0-1234-56789abcdef0","key":"oV9AZYb6xHuZWXDxhdnYkcdNzx65Gn1QpYsBaD5gBS0="}]}
{"keys":[{"id":"14345678-9abc-def0-1234-56789abcdef0","key":"oV9AZYb6xHuZWXDxhdnYkcdNzx65Gn1QpYsBaD5gBS0="}]}

0 comments on commit 82464df

Please sign in to comment.