Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust more timeouts #4264

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Adjust more timeouts #4264

merged 2 commits into from
Feb 13, 2025

Conversation

jcscottiii
Copy link
Collaborator

@jcscottiii jcscottiii commented Feb 13, 2025 •
edited
Loading

This change increases various NGINX timeouts to high values (e.g., client body, header, read timeouts). The goal is to let the Go application handle timeout configurations and prevent resource exhaustion on the NGINX side. This approach is temporary until the Go application can be migrated away from nicehttp.

Why this change:

  • Previously, some requests were failing at 60 seconds, likely due to the NGINX timeout settings and the limited capacity of the smaller instances. This change increases various NGINX timeouts (e.g., client body, header, read timeouts) and sets a high keepalive timeout to allow the Go application to handle timeout logic. I have not seen any requests taking longer than 60 seconds today after yesterday's changes. So this is a proactive change.
  • This should prevent requests from failing with the larger instances, even under increased demand. It might also allow us to reduce the instance size slightly in the future.

@jcscottiii
Adjust more timeouts
322a567 
This change disables most NGINX timeout checks (e.g., client body, header, read timeouts)
and sets the keepalive timeout to a high value. The goal is to let the Go application
handle timeout configurations and prevent resource exhaustion on the NGINX side.
This approach is temporary until the Go application can be migrated away from `nicehttp`.
@jcscottiii
Copy link
Collaborator Author

Turns out these aren't working as expected.

@jcscottiii jcscottiii marked this pull request as draft February 13, 2025 16:16
@jcscottiii jcscottiii marked this pull request as ready for review February 13, 2025 17:47
@jcscottiii
Copy link
Collaborator Author

@past @DanielRyanSmith sorry for all the notifications. Now this is ready again.

DanielRyanSmith
DanielRyanSmith reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@DanielRyanSmith DanielRyanSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for assisting with this. 🙂

@jcscottiii jcscottiii merged commit 1582508 into main Feb 13, 2025
12 checks passed
@jcscottiii jcscottiii deleted the adjusts-more-timeouts branch February 13, 2025 18:08
jcscottiii added a commit that referenced this pull request Feb 14, 2025
@jcscottiii
Revert "Adjust more timeouts (#4264)"
bf613f4 
This reverts commit 1582508.
@jcscottiii jcscottiii mentioned this pull request Feb 14, 2025
Merged
jcscottiii added a commit that referenced this pull request Feb 14, 2025
@jcscottiii
Revert "Adjust more timeouts (#4264)" (#4267)
359cd8b 
This reverts commit 1582508.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRyanSmith DanielRyanSmith DanielRyanSmith approved these changes

@past past Awaiting requested review from past

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcscottiii @DanielRyanSmith