Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 80: Rename master branch to main in all repositories #80

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

foolip
Copy link
Member

@foolip foolip commented Apr 30, 2021

@foolip foolip changed the title Rename master branch to main in all repositories RFC 80: Rename master branch to main in all repositories Apr 30, 2021
- https://github.com/web-platform-tests/wpt.fyi
- https://github.com/web-platform-tests/wpt.live

TODO: which external repos hardcode the name of the default branch in any WPT repo?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably many bots that interact with wpt e.g. the gecko sync bot definitely has some hardcoded branch names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't planning to flesh this out today, but I think what I'd propose here to make the transition work is to have both main and master branch updated and kept in sync for a while, so that the migration in other repos can happen at a leisurely pace and not strongly coordinated with the default branch change.

The alternative of having other repos be able to handle both branch names and later clean it up seems riskier and very un-fun.

@foolip
Copy link
Member Author

foolip commented Apr 30, 2021

@stephenmcgruer and @Hexcles (feel free to unsubscribe) put together WPT and wpt.fyi - inclusive branch naming last year, which has much of the detail needed here.

@foolip
Copy link
Member Author

foolip commented Sep 10, 2021

If someone would like to take over this RFC and drive it to completion, I would be very happy. It's a lot of work to ensure this change won't break anything given all the repos involved, and also things like https://wpt.fyi/results/?label=experimental&label=master&aligned where we'd need some changes in wpt.fyi.

@gsnedders
Copy link
Member

gsnedders commented Oct 25, 2023

FYI, non-archived repos with default branches which aren't main:

https://github.com/web-platform-tests/code-of-conduct-moderations (master)
https://github.com/web-platform-tests/data-migration (master)
https://github.com/web-platform-tests/editor (master)
https://github.com/web-platform-tests/rfcs (master)
https://github.com/web-platform-tests/wpt (master)
https://github.com/web-platform-tests/wpt-metadata (master)
https://github.com/web-platform-tests/wpt-notes (master)
https://github.com/web-platform-tests/wpt.live (master)

It does seem like we should be able to move almost all of these over with minimal risk.

I do wonder if we should split this RFC into two, one covering WPT itself and one covering the rest.

@foolip
Copy link
Member Author

foolip commented Nov 10, 2023

The second riskiest I think might be wpt-metadata, since there are multiple pieces of code creating automated pull requests. Creating a pull request requires a target branch, so that'll need updating.

But I agree splitting into multiple RFC. For the not-wpt RFC, I expect the discussion to just be "try it and see what breaks", for wpt we need to be a bit more responsible.

@foolip
Copy link
Member Author

foolip commented May 14, 2024

For anyone coming across this, I do not plan to work on this. Feel free to take it over as a new RFC and I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants