Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 199: Add Bazel configuration files #210

Closed

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 16, 2024

Following up for the changes on web-platform-tests/wpt#48084, I'd like to propose adding 2 Bazel files to web-platform tests to make integrations as seamless as possible.

cc @jasnell

Note: This RFC does not propose running WPT on Bazel. It proposes adding Bazel files to the git repository so that the implementors such as Cloudflare Workers can easily run WPT without any modifications.

@anonrig
Copy link
Member Author

anonrig commented Sep 23, 2024

hey @jgraham, what are the next steps?

Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My high-level concern here is that this seems to embed vendor-specific configuration decisions into the shared repository. We generally try to avoid that e.g. we don't have moz.build files from mozilla or ninja files from Chromium. It seems potentially confusing for users to see a Bazel file and assume that there might be some requirement to use Bazel in order to run the tests. Even for other vendors who are using Bazel it's not clear to me to what extent the proposal here is generic to any use case / setup vs encoding cloudflare-specific decisions (for example, maybe other vendors don't want the same division of tests by directories? I'm not sure).

It seems like web-platform-tests/wpt#48084 (comment) has some suggestions for alternate approaches that might not require landing this configuration in the upstream repo; I'd suggest starting with that and only proceeding with this approach if that can't work, or if there is clear multi-vendor demand for the same Bazel setup.

@anonrig anonrig closed this Oct 26, 2024
@anonrig anonrig deleted the anonrig/add-bazel-files branch October 26, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants