-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 117: Remove dated tags for epoch branches #117
base: master
Are you sure you want to change the base?
Conversation
I still rely on this tags when there is a issue with WebKitGTK on the CI that needs to be investigated. That would be my preferred option (purge automatically old tags), but I'm a sporadic user of this feature, so I'm fine relying instead on the command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we rely on this for anything, so no objections on that front, but the RFC doesn't seem to set ouf the case for the change, only that there are alternative ways to get the same information.
The other potential option here would be to use a different namespace for the epoch refs, such as pushing them into This has the upside that omits them from the default refspec, which means normally users won't constantly see the branches/tags used for them. (We could also do likewise with the |
Can you describe how you use the existing tags? Is it to figure out which runs have been triggered in order to find the CI runs in the first place, or is it when you're already looking at a failed CI run and want to find some previous run? Or something else? |
My motivation is to make |
That would be a ~breaking change for the gecko sync (we use the tags in the first instance to associate a commit on master with a PR). Not impossible to update ofc, but not something we should just blindly change. |
Can you update the RFC with this reasoning? |
We also need regular tags to create releases, and release artifacts is how we store the manifests. I would like to get rid of those tags (and lots of branches) too but that's not for this RFC. |
Will do after I've heard from @clopez. It's still possible I've misunderstood what these tags are for. |
ah, that's true; yeah, probably worthwhile as a separate discussion |
I use them to find the commit that triggered the runs on a given day, so I can check the CI.
So I use this tags to map a run on a given day to a commit hash (step 3). If this tags are gone then I would have to rely instead on this command
And pick the second entry (d3422cc02be67fe0eaf5fe9df4c105a592d0d71c) that would be the one mapping the run for the 12th of July. So, not a big issue for me if this tags get removed as the However my preference would be to automatically purge old tags (to avoid ending with thousands of tags) rather than stop tagging since I find convenient this tags. But is not a strong preference in any case, feel free to push this if you think is better to remove the tags. |
That would be also a good option, i like it. It keeps the info for those interested on it (via |
No description provided.