Skip to content

Commit

Permalink
Mention screenshot requirement
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathan-j-lee committed Dec 4, 2024
1 parent 2580284 commit 7ee02b9
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions rfcs/testdriver_in_other_types.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,9 @@ without needing to re-parse test files themselves.
As a concrete example, Gecko runs reftests using an internal endpoint, which
is not set up to work with a testdriver event loop.
For these vendors, an acceptable workaround might be to fall back to the
WebDriver reftest implementation, which only requires an ["execute async
script" implementation][execute-async-script].
WebDriver reftest implementation, which only requires ["execute async
script"][execute-async-script] and ["take screenshot"][take-screenshot]
implementations.
* Even with testdriver support, some APIs may still be challenging to test
reliably.
For example, the classic `<select>` picker in mainstream browsers is rendered
Expand All @@ -148,3 +149,4 @@ without needing to re-parse test files themselves.
Test reviewers should exercise their judgement in these cases.

[execute-async-script]: https://github.com/web-platform-tests/wpt/blob/f3dcc205a202467a922386036791372cd3e372fd/tools/wptrunner/wptrunner/executors/executorwebdriver.py#L969
[take-screenshot]: https://www.w3.org/TR/webdriver/#take-screenshot

0 comments on commit 7ee02b9

Please sign in to comment.