Skip to content

Adds the at-rule feature #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 3, 2025
Merged

Adds the at-rule feature #3449

merged 16 commits into from
Nov 3, 2025
+10 −0

Conversation

@diekus
Copy link
Contributor

@diekus diekus commented Oct 14, 2025 •
edited by captainbrosset
Loading

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 14, 2025
captainbrosset
captainbrosset reviewed Oct 14, 2025
View reviewed changes
captainbrosset
captainbrosset requested changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions for the name and description.

diekus and others added 2 commits October 14, 2025 15:22
@diekus @captainbrosset
Update features/at-rule.yml
1d7e54a 
Co-authored-by: Patrick Brosset <[email protected]>
@diekus @captainbrosset
Update features/at-rule.yml
4d00414 
Co-authored-by: Patrick Brosset <[email protected]>
@ddbeck ddbeck mentioned this pull request Oct 16, 2025
Open
14 tasks
ddbeck
ddbeck reviewed Oct 16, 2025
View reviewed changes
@diekus
Copy link
Contributor Author

diekus commented Oct 17, 2025 •
edited
Loading

I've changed the ID of the feature, renamed the files, the description is now clearer and regenerated the dist.yml file.

cc @captainbrosset

ddbeck
ddbeck reviewed Oct 17, 2025
View reviewed changes
@diekus diekus requested a review from ddbeck October 21, 2025 14:10
captainbrosset
captainbrosset reviewed Oct 29, 2025
View reviewed changes
captainbrosset
captainbrosset reviewed Oct 29, 2025
View reviewed changes
@captainbrosset
Copy link
Contributor

@foolip @ddbeck I've approved this after changing the spec URL. Any more comments from your end before we merge?

ddbeck
ddbeck requested changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for the spec URL (the PR merged). This also needs to be formatted to pass the linter, npm run format and a commit should fix it.

captainbrosset
captainbrosset reviewed Nov 3, 2025
View reviewed changes
@ddbeck ddbeck enabled auto-merge (squash) November 3, 2025 16:16
@ddbeck ddbeck merged commit 0f7601c into web-platform-dx:main Nov 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@captainbrosset captainbrosset captainbrosset approved these changes

@ddbeck ddbeck ddbeck approved these changes

@foolip foolip Awaiting requested review from foolip

Assignees

No one assigned

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@diekus @captainbrosset @ddbeck @foolip