-
Notifications
You must be signed in to change notification settings - Fork 177
Revise input-color-alpha
name and description
#3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
input-color-alpha
name an descriptioninput-color-alpha
name and description
d554d3d
to
b9e1a65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the long run both of these properties will be merged into input type=color
, so while I don't mind splitting them up, I also don't think it's necessary unless different browsers implement the two properties at different times.
description: The ability to control the opacity of a color picked using `<input type="color">` and determine the colorspace of the selected color. | ||
name: > | ||
alpha and colorspace attributes for <input type="color"> | ||
description: The `alpha` and `colorspace` attributes for the `<input type="color">` HTML element are hints to the browser to show controls for transparency or to limit color selection to a color space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attributes aren't just non-normative hints, as this description suggests. If you set the alpha
attribute then the browser will serialize the color with opacity data. If you set the colorspace property then the browser will serialize the color in the format for the requested colorspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this:
description: The `alpha` and `colorspace` attributes for the `<input type="color">` HTML element are hints to the browser to show controls for transparency or to limit color selection to a color space. | |
description: The `alpha` and `colorspace` attributes for the `<input type="color">` HTML element show controls for transparency and color space color selection in the color picker interface. Additionally, they determine the format of the selected value. |
name: > | ||
alpha and colorspace attributes for <input type="color"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with features like https://web-platform-dx.github.io/web-features-explorer/features/input-number/ or https://web-platform-dx.github.io/web-features-explorer/features/dialog-closedby/, maybe we should rename this to:
name: > | |
alpha and colorspace attributes for <input type="color"> | |
name: <input type="color" alpha> and <input type="color" colorspace> |
description: The ability to control the opacity of a color picked using `<input type="color">` and determine the colorspace of the selected color. | ||
name: > | ||
alpha and colorspace attributes for <input type="color"> | ||
description: The `alpha` and `colorspace` attributes for the `<input type="color">` HTML element are hints to the browser to show controls for transparency or to limit color selection to a color space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this:
description: The `alpha` and `colorspace` attributes for the `<input type="color">` HTML element are hints to the browser to show controls for transparency or to limit color selection to a color space. | |
description: The `alpha` and `colorspace` attributes for the `<input type="color">` HTML element show controls for transparency and color space color selection in the color picker interface. Additionally, they determine the format of the selected value. |
A follow up to #3367. Neither the name nor the description satisfy the guidelines, so I'm suggesting we revise this to at least satisfy those requirements.
That said, I don't think this makes sense as one feature. They're rather dissimilar in what they do. If this is still open when I return next week, I'm going update this PR to split this feature in two (otherwise, I'll open a followup PR).