Update GH Pages to 11ty 3#2316
Conversation
github-actions
Bot
added
the
tools and infrastructure
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Ugh, sorry for the late review. I had a pending comment that I just… never submitted. 🤦
| import { EleventyHtmlBasePlugin } from "@11ty/eleventy"; | ||
| import markdownIt from "markdown-it"; | ||
| import markdownItAnchor from "markdown-it-anchor"; | ||
| import UpgradeHelper from "@11ty/eleventy-upgrade-help"; |
There was a problem hiding this comment.
From the README, it seems like maybe this isn't something we're supposed to keep around? It's also not in the package.json, so I'm thinking that this is maybe unintentionally left over?
Run your usual build command (e.g. npm run build) and pay attention to the output. Address any violations and warnings. Once you’ve removed all of the violations/warnings from your output, run npm uninstall @11ty/eleventy-upgrade-help to remove the plugin and delete its code from your Eleventy configuration file.
There was a problem hiding this comment.
Good catch- I forgot to clean that up, so I dd that now.
It does bring up that we aren't testing the gh-pages build in PRs, but since that's the minority of PRs, should we?
3 participants
Also noticed Github pages was excluded from Dependabot, so I added it there.