feat: using runtime_template to support output.environment#9052
Merged
GiveMe-A-Name merged 2 commits intoweb-infra-dev:mainfrom Jan 20, 2025
Merged
feat: using runtime_template to support output.environment#9052GiveMe-A-Name merged 2 commits intoweb-infra-dev:mainfrom
GiveMe-A-Name merged 2 commits intoweb-infra-dev:mainfrom
Conversation
- Introduced new runtime template in `runtime_template.rs` to support enhanced functionality. - Adjusted raw output handling in `raw_output.rs` for improved performance. - Updated various snapshot tests to reflect changes in output and ensure consistency. These changes aim to improve the overall type safety and reduce production size.
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging #9052 will not alter performanceComparing 🎉 Hooray!
|
LingyuCoder
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime_template.rsto support enhanced functionality.raw_output.rsfor improved performance.These changes aim to improve the overall type safety and reduce production size.
related to #5316
Checklist