Skip to content

feat: using runtime_template to support output.environment#9052

Merged
GiveMe-A-Name merged 2 commits intoweb-infra-dev:mainfrom
GiveMe-A-Name:feat/runtime-template
Jan 20, 2025
Merged

feat: using runtime_template to support output.environment#9052
GiveMe-A-Name merged 2 commits intoweb-infra-dev:mainfrom
GiveMe-A-Name:feat/runtime-template

Conversation

@GiveMe-A-Name
Copy link
Copy Markdown
Member

Summary

  • Introduced new runtime template in runtime_template.rs to support enhanced functionality.
  • Adjusted raw output handling in raw_output.rs for improved performance.
  • Updated various snapshot tests to reflect changes in output and ensure consistency.

These changes aim to improve the overall type safety and reduce production size.
related to #5316

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

- Introduced new runtime template in `runtime_template.rs` to support enhanced functionality.
- Adjusted raw output handling in `raw_output.rs` for improved performance.
- Updated various snapshot tests to reflect changes in output and ensure consistency.

These changes aim to improve the overall type safety and reduce production size.
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 20, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 447f6fd
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/678e0bbeeaf4ea0008a61a1b

@GiveMe-A-Name GiveMe-A-Name added the team The issue/pr is created by the member of Rspack. label Jan 20, 2025
@GiveMe-A-Name GiveMe-A-Name reopened this Jan 20, 2025
@GiveMe-A-Name GiveMe-A-Name added the feat New feature or request label Jan 20, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #9052 will not alter performance

Comparing GiveMe-A-Name:feat/runtime-template (447f6fd) with main (1c0a097)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@GiveMe-A-Name GiveMe-A-Name merged commit 2165f1b into web-infra-dev:main Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature or request team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants