Skip to content

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jun 29, 2025

Summary

Updated getTagSrc() to only process <link> tags that actually load resources requiring SRI:

  • Process: stylesheet, modulepreload, preload (script/style only)
  • Skip: dns-prefetch, preconnect, prefetch, icon, etc.

This prevents unnecessary SRI processing on hint/metadata tags and improves plugin accuracy.

Related links

See MDN:

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Jun 29, 2025
@netlify
Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit dccfcd3
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68609f09b95c600008c774a1

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 29, 2025

CodSpeed Performance Report

Merging #10829 will not alter performance

Comparing sri_skip_0629 (dccfcd3) with main (ce4eb8f)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@chenjiahan chenjiahan merged commit 7637ddf into main Jun 30, 2025
39 checks passed
@chenjiahan chenjiahan deleted the sri_skip_0629 branch June 30, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: throw error when use performance.dnsPrefetch and security.sri together

3 participants