Clamp animation progress to [0, 1] to prevent reset on overscroll #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2 by clamping the animation progress in the
currentTimegetter to the[0, 1]range. This prevents the animation from exceeding its intended bounds and ensures a smooth, predictable experience even during overscroll.This is a change to
scroll-timelinethough, so preferably should be done upstream, but it seems that project has been abandoned? This bug also seems quite fundamental and I would expect it to have been caught already, is there a reason it perhaps hasn't – are there unexpected side-effects from solving the issue this way...