Clarify git-provider-token in logging

- Again remove the JWTAuthorizationHeaderPrincipalGetter debug statement, its not very useful
weaveworks · Jan 26, 2023 · 21c8080 · bigkevmcd · Jan 26, 2023 · 21c8080
1 parent 553aba1
commit 21c8080
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/pkg/server/auth/jwt.go b/pkg/server/auth/jwt.go
@@ -74,8 +74,6 @@ func NewJWTAuthorizationHeaderPrincipalGetter(log logr.Logger, verifier tokenVer
 }
 
 func (pg *JWTAuthorizationHeaderPrincipalGetter) Principal(r *http.Request) (*UserPrincipal, error) {
-	pg.log.V(logger.LogLevelDebug).Info("attempt to read token from auth header")
-
 	header := r.Header.Get("Authorization")
 	if header == "" {
 		return nil, nil

diff --git a/pkg/server/middleware/middleware.go b/pkg/server/middleware/middleware.go
@@ -87,7 +87,7 @@ func WithProviderToken(jwtClient auth.JWTClient, h http.Handler, log logr.Logger
 		tokenSlice := strings.Split(tokenStr, "token ")
 
 		if len(tokenSlice) < 2 {
-			log.V(logger.LogLevelDebug).Info("missing or invalid token.")
+			log.V(logger.LogLevelDebug).Info("missing or invalid git-provider-token.")
 			// No token specified. Nothing to be done.
 			// We do NOT return 400 here because there may be some 'unauthenticated' routes (ie /login)
 			h.ServeHTTP(w, r)