chore(deps): upgrade omniauth-rails_csrf_protection to 2.0.1#2449
chore(deps): upgrade omniauth-rails_csrf_protection to 2.0.1#2449JSONbored wants to merge 1 commit into
Conversation
Resolves an ActiveSupport::Configurable deprecation warning emitted at boot on Rails 8.1. The warning states it will become an error in Rails 8.2, blocking the upgrade path. v2.0.1 avoids the deprecated include on Rails >= 8.1 by delegating `config` directly to ActionController::Base.config instead.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
jjmata
left a comment
There was a problem hiding this comment.
One thing worth checking before merging: this is a major version bump (1.0.2 → 2.0.1). The omniauth-rails_csrf_protection gem's 2.x series may have breaking changes around how it hooks into OmniAuth's request phase or how it validates CSRF tokens on the callback. It's worth reviewing the gem's CHANGELOG/release notes to confirm there are no behaviour changes that could affect login flows (OAuth, SAML, API key auth via OmniAuth). If CI exercises the auth flows end-to-end, those tests passing is a good signal; if not, a quick manual smoke-test of at least one OmniAuth-backed sign-in path before merging would be prudent.
Generated by Claude Code
|
Thanks @jjmata — reviewed the gem CHANGELOG and our usage; the bump is safe (and actually well-aligned with our stack). No code change needed. What changed (1.0.2 → 2.0.1):
Why it's fine for us:
Auth coverage: |
Closes #2448
What
Bumps
omniauth-rails_csrf_protectionfrom 1.0.2 → 2.0.1. OnlyGemfile.lockchanges; no application code is modified.Why
v1.0.2 unconditionally calls
include ActiveSupport::ConfigurableinsideTokenVerifier. Rails 8.1 deprecates this usage with a boot-time warning that it will be removed in Rails 8.2, blocking the upgrade path.v2.0.1 detects the Rails version at load time:
configtoActionController::Base.configdirectly — noActiveSupport::Configurabletouched.includeso older installs are unaffected.Test plan
bin/rails testpasses (no regressions introduced)ActiveSupport::Configurabledeprecationtest/controllers/sessions_controller_test.rb(31 tests, all green)