fix(settings): securities-provider checkmarks invisible in dark mode#2430
fix(settings): securities-provider checkmarks invisible in dark mode#2430vlnd0 wants to merge 1 commit into
Conversation
The securities-provider checkboxes used raw Tailwind utilities (rounded border-primary text-primary focus:ring-primary) instead of the design-system .checkbox component. In dark mode text-primary resolves to white, so a checked box rendered a white check on a white fill and the checkmark was invisible. Switch to the theme-aware .checkbox checkbox--light classes used by every other checkbox in the app (settings/preferences, transaction filters, etc.), which render a dark check on a light fill in dark mode.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single CSS class attribute on a checkbox input in ChangesCheckbox styling in provider selection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
this would be great! |
|
@jjmata if all ok, i suggest to merge |
Problem
On the hosting settings page ("Securities Providers"), the checkboxes are invisible when checked in dark mode — a checked box shows a white check on a white fill, so there's no visual indication of which providers are enabled.
Cause
app/views/settings/hostings/_provider_selection.html.erbstyled the checkbox with raw Tailwind utilities:In dark mode
text-primaryresolves to white. The browser's checked state fills the box withcurrentColorand draws the checkmark in white → white-on-white.Every other checkbox in the app uses the theme-aware design-system component (
settings/preferences, transaction filters, goals, trades, etc.):.checkbox--lighthas a@variant theme-darkblock that renders a dark check on a light fill in dark mode.Fix
Use the design-system
checkbox checkbox--lightclasses, consistent with the rest of the app. One-line change.Test
Summary by CodeRabbit