Skip to content

Fixes issue #2415 - Subcategories are not alphabetically ordered like Categories #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjmata merged 4 commits into from
Jun 28, 2026
Merged

Fixes issue #2415 - Subcategories are not alphabetically ordered like Categories #2429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d408deb
Update categories_controller.rb
HairyHook Jun 21, 2026
30e86d2
Subcategory ordering fix 1 in category.rb
HairyHook Jun 21, 2026
5d5987a
Update categories_controller.rb
HairyHook Jun 21, 2026
571eace
Merge pull request #1 from HairyHook/fix-subcategory-ordering-1
HairyHook Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/categories_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class CategoriesController < ApplicationController
before_action :set_transaction, only: :create

def index
@categories = Current.family.categories.alphabetically.to_a
@categories = Current.family.categories.alphabetically_by_hierarchy.to_a
@category_groups = Category::Group.for(@categories)
@category_ids_with_transactions = category_ids_with_transactions(@categories)

Expand Down
6 changes: 5 additions & 1 deletion app/models/category.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ class Category < ApplicationRecord
belongs_to :family

has_many :budget_categories, dependent: :destroy
has_many :subcategories, class_name: "Category", foreign_key: :parent_id, dependent: :nullify
has_many :subcategories,
-> { order(:name) },
class_name: "Category",
foreign_key: :parent_id,
dependent: :nullify
belongs_to :parent, class_name: "Category", optional: true

validates :name, :color, :lucide_icon, :family, presence: true
Expand Down
Loading