-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Updater implementation #307
Open
QU3B1M
wants to merge
11
commits into
main
Choose a base branch
from
enhancement/256-content-updater
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve names Add ContentUpdater module
Remove duplicated constants definitions
d20283c
to
19e5d13
Compare
Update fetched Offsets on ContentUpdate with every new batch to make a batch patch
…enum Update docstrings and code styling on CTIClient Implement command posting on ContentUpdater Rename functions and variables on ContentUpdater
Change functions visibility
Remove non-working Unit Tests
Signed-off-by: Álex Ruiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the
ContentUpdater
class to handle the Context's changes fetching and patching, posting to theCommandManager
API once the update is successful.Some minor changes were applied to the
CTIClient
avoiding duplicated code, the affected code is also updated.Issues Resolved
Closes #256