feature: allow edit selection area - #124
Merged
Decodetalkers merged 4 commits intoJul 26, 2026
Merged
Conversation
Collaborator
|
Looks fine. merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature to edit the selected area before printing the resulting output.
To be more precise, the code allows changing selection rectangle bounds, allows dragging rectangle around, shows crosshair cursor when in selection area.
The code is behind a new flags:
--edit-selection/-eand--edit-selection-key <keycode>. Since this doesn't introduce any new deps I decided that it'd be an overkill to separate it behind cargo feat.The consumers that doesn't use this feat will not be affected by this change.Closes: #6
2026-07-25.23-29-20.mp4
One thing I only not sure is, the out of bounds cases. By dragging rectangle out of screen we can see the negative/overflow values:
2026-07-25.23-31-10.mp4
For consumers (e.g.
wayshot) that expects a correct string, out-of-bounds results will result in panic. I wonder, if we should add a guards here, like setting making negative values to0before outputting them, or it is fine as-is.