Skip to content

fix: prefer the transform by ext-image-copy - #425

Merged
Decodetalkers merged 1 commit into
mainfrom
fix/transform
Aug 4, 2026
Merged

fix: prefer the transform by ext-image-copy#425
Decodetalkers merged 1 commit into
mainfrom
fix/transform

Conversation

@Decodetalkers

Copy link
Copy Markdown
Collaborator

resolve: #359

before we use the transform by wl-output to address the final image, but it is wrong. now ext-image-copy provide us the real transform of the image, we need to use it first, if we have to use the wlr-screencopy, then we use the transform of the screen

@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.37%. Comparing base (ac949d4) to head (922b4a1).

Files with missing lines Patch % Lines
libwayshot/src/lib.rs 0.00% 5 Missing ⚠️
libwayshot/src/dispatch.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #425      +/-   ##
========================================
+ Coverage   8.35%   8.37%   +0.01%     
========================================
  Files         19      19              
  Lines       2944    2950       +6     
========================================
+ Hits         246     247       +1     
- Misses      2698    2703       +5     
Flag Coverage Δ
libwayshot 11.92% <10.00%> (+0.01%) ⬆️
wayshot 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

resolve: #359

before we use the transform by wl-output to address the final image, but
it is wrong. now ext-image-copy provide us the real transform of the
image, we need to use it first, if we have to use the wlr-screencopy,
then we use the transform of the screen

@Gigas002 Gigas002 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Decodetalkers
Decodetalkers merged commit ba52ac2 into main Aug 4, 2026
27 checks passed
@Decodetalkers
Decodetalkers deleted the fix/transform branch August 4, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Region Aware Multimonitor Support

3 participants