Ride vm and compiler. #438
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cmd/node/node.go # pkg/ride/constants.go
…ide_vm_fsm # Conflicts: # go.mod # go.sum # pkg/ride/compiler_test.go # pkg/ride/tree_evaluation.go # pkg/ride/tree_expand_test.go
esuwu
reviewed
Mar 25, 2021
|
|
||
| .PHONY: vendor vetcheck fmtcheck clean build gotest | ||
|
|
||
| all: vendor vetcheck fmtcheck build gotest mod-clean |
There was a problem hiding this comment.
It's better to skip a package instead of removing fmtcheck at all in case if it's hard to fix style and stuff
There was a problem hiding this comment.
I've tried all possible ways - skip, ignore, fix, upgrade. Nothing helps.
alexeykiselev
added
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.