Skip to content

BSM2 Translator & Scaling Revisions#1846

Draft
MarcusHolly wants to merge 9 commits into
watertap-org:mainfrom
MarcusHolly:bsm2_xpp_correction
Draft

BSM2 Translator & Scaling Revisions#1846
MarcusHolly wants to merge 9 commits into
watertap-org:mainfrom
MarcusHolly:bsm2_xpp_correction

Conversation

@MarcusHolly

@MarcusHolly MarcusHolly commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary/Motivation:

There was a mistake in the implementation of X_PP in the modified ADM1 reaction package and ADM1-ASM2d translator

Changes proposed in this PR:

  • Fixes implementation of X_PP
  • Updates pyproject.toml to use latest IDAES scaling functionality
  • Updates scaling in BSM2 flowsheets

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this Jul 6, 2026
@sufikaur sufikaur added iedo Priority:High High Priority Issue or PR labels Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iedo Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants