Skip to content

Add detailed pump model #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kurbansitterley merged 31 commits into from
Mar 12, 2026
Merged

Add detailed pump model #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
cedee8b
Detailed pump model, utilities updated
MuktaHardikar Feb 11, 2026
46e3410
Updated test file for head-speed case.
MuktaHardikar Feb 12, 2026
edcdfb3
added comments
MuktaHardikar Feb 12, 2026
5a28ada
test notebook
MuktaHardikar Feb 12, 2026
6dbc2fe
Create config for the surrogate coefficients to be passed as inputs
Feb 12, 2026
8d4a4f2
pump can take dataframe directly to build surrogate for head and effi…
Feb 12, 2026
7ad7efb
Now pump takes filepath name and loads data
Feb 12, 2026
5588971
Validation tests for ro feed and uf pumps implimented
Feb 13, 2026
4595788
black
Feb 13, 2026
b518770
Addressing comments, making units consistient. Tests passing.
Feb 13, 2026
ae19a55
Added fixed eff test and changed fit order to Param
Feb 13, 2026
d769c10
black
Feb 13, 2026
87af9b2
removed test notebook, updates to docs in unit model, added bounds, u…
MuktaHardikar Feb 18, 2026
2bef5dd
fix test_uf_pump
MuktaHardikar Feb 18, 2026
a211195
changed test_uf_pump to solve with fixed speed and head. Doubles as l…
Feb 18, 2026
f2bc83b
Add costing method
MuktaHardikar Feb 19, 2026
a75f910
remove efficiency adjustment factor
MuktaHardikar Feb 23, 2026
666c54c
creating file for testing uf pump operational data against
Feb 24, 2026
4f14bee
Updated uf pump tests to have negative inlet pressure
Feb 25, 2026
b80ba53
clean up imports
kurbansitterley Mar 2, 2026
de326a2
Requiring surrogate to be 3rd order polynomial
Mar 2, 2026
43a5531
Adding Configuration Error tests
Mar 2, 2026
26e4968
Merge branch 'detailed_pump_model' of https://github.com/muktahardika…
Mar 2, 2026
08c7d7f
Moved validation functions, changed 9.81 to a constant
Mar 2, 2026
adb4a6f
Moved pressure bounds into unit model. Added idea for improved initia…
Mar 2, 2026
696bf0e
Added bounds to head and flow Vars and renamed the Pump class to Pump…
Mar 3, 2026
84a65c3
black
Mar 3, 2026
6edf4da
Moved configuration error logic to a validate config function
Mar 3, 2026
54d59e3
Fixed pump import in uf_pump_test
Mar 3, 2026
a9cc5bb
Moved relaxing pressure bounds from component model to flowsheet level
Mar 12, 2026
5f38605
black
Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading