Replace set of if/elif with dictionary. #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set of if/elif mimics the switch construct which is not explicitly available in Python. A more pythonic approach is to use a dictionary and try-except. This commit also addresses the issue of providing an invalid class_type resulting in a NameError. In the original code the masks name would not be set and the code tries to access it after the if/elif section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of if/elif mimics the switch construct which is not explicitly available in Python. A more pythonic approach is to use a dictionary and try-except.
This commit also addresses the issue of providing an invalid class_type resulting in a NameError. In the original code the masks name would not be set and the code tries to access it after the if/elif section.