App spec json #2284
App spec json #2284
Conversation
| takeDecls, | ||
| makeDecl, | ||
| fromDecl, | ||
| ) | ||
| where | ||
|
|
||
| import Data.Maybe (mapMaybe) | ||
| import Data.Typeable (Typeable, cast) | ||
|
|
||
| class (Typeable a) => IsDecl a |
There was a problem hiding this comment.
I took IsDecl from here to its own file to avoid circular dependencies.
There was a problem hiding this comment.
Here is the main logic (well, generated by TH, which is in JSON/TH.hs file). TH logic has to be in another file (in JSON/TH.hs), GHC demanded it, has to do with order in which stuff is compiled.
In this file are the main TODOs.
There was a problem hiding this comment.
Btw cool trick I learned: add {-# OPTIONS_GHC -ddump-splices #-} at the top, run cabal build, and you will, in compiler output in stdout, the contents of this file as generated by TH.
|
|
||
| import Data.Typeable (Proxy (Proxy), Typeable, typeRep) | ||
|
|
||
| class (Typeable a) => IsDecl a where |
There was a problem hiding this comment.
As mentioned above, I just moved this from Decl.hs to here, in this standalone file, to avoid circ deps.
| @@ -25,3 +27,16 @@ deriving instance (IsDecl a, Data a) => Data (Ref a) | |||
|
|
|||
| refName :: Ref a -> String | |||
| refName (Ref name) = name | |||
|
|
|||
| instance (IsDecl a) => FromJSON (Ref a) where | |||
There was a problem hiding this comment.
Here we expect JSON to contain not just the declaration identifier name, but also its declaration type. We could drop that if we want, but then all identifiers need to be unique and I actually wasn't sure if that is so now. Also I thought it can't hurt.
| @@ -30,6 +31,9 @@ data Entity = Entity | |||
|
|
|||
| instance IsDecl Entity | |||
|
|
|||
| instance FromJSON Entity where | |||
There was a problem hiding this comment.
We don't allow defining entities via Wasp file any more, but we left some of the old machinery in for now since it was easier then purging it, so I just put this error here, I think this should be quite fine for now.
| deriving (Show, Eq, Data) | ||
| deriving (Show, Eq, Data, Generic) | ||
|
|
||
| instance FromJSON ExtImport where |
There was a problem hiding this comment.
Here I manually implemented JSON parsing in order to explain how to parse the StrongPath in question.
sodic
force-pushed
the
app-spec-json
branch
from
8b1b8a5
to
3a32723
Compare
waspc/src/Wasp/AppSpec/Core/Decl.hs
Outdated
| {-# LANGUAGE AllowAmbiguousTypes #-} | ||
| {-# LANGUAGE BlockArguments #-} |
There was a problem hiding this comment.
Do we need these here? Probably not.
| {-# LANGUAGE TypeApplications #-} -- Needed by generateFromJsonInstanceForDecl (TH) | ||
| {-# OPTIONS_GHC -Wno-orphans #-} |
|
|
||
| import Data.Typeable (Proxy (Proxy), Typeable, typeRep) | ||
|
|
||
| class (Typeable a) => IsDecl a where |
@sodic please take this one and finish it! I think I got it quite far: check TODOs in the code, and see how usable is it for you.