-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates actions in the CI #2239
base: main
Are you sure you want to change the base?
Conversation
@@ -11,15 +11,15 @@ If you would like to make your first contribution, here is a handy checklist we | |||
- [ ] Read [Quick overview](#quick-overview). | |||
- [ ] Compile the project successfully and get todoApp example running (follow [Basics](#basics)). | |||
- [ ] Join [Discord](https://discord.gg/rzdnErX) and say hi :)! | |||
- [ ] Pick an issue [labeled with "good first issue"](https://github.com/wasp-lang/wasp/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) and let us know you would like to work on it - ideally immediatelly propose a plan of action and ask questions. | |||
- [ ] Pick an issue [labeled with "good first issue"](https://github.com/wasp-lang/wasp/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) and let us know you would like to work on it - ideally immediately propose a plan of action and ask questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in waspc
dir to trigger the CI
What would also help is us upgrading to the newer GHC! This happens only for <= 9.0 . |
@Martinsos How big of an undertaking is to upgrade to GHC 9.X? |
Ha not sure, if I had to estimate it now, I would say it would take me, who knows the Haskell setup we currently have the best, probably a couple of days. Depends if hit any dep that is problematic or not. I would say 2 days if we are lucky, 5 days if there are a lot of deps that need a major update (Tasty testing suite might be such one). |
Issue we have here: #1446 , you opened it. We could go after this sooner than later. |
The action we used to setup Haskell got deprecated: https://github.com/haskell/actions?tab=readme-ov-file
EDIT: this might be a no go, since MacOS builds fail. Related issue: haskell-actions/setup#77 -> workaround is to use MacOS 13 instead of the latest MacOS 14.