-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replyTo field to SendGrid provider and Email type #2045
base: release
Are you sure you want to change the base?
Add replyTo field to SendGrid provider and Email type #2045
Conversation
@@ -1,5 +1,11 @@ | |||
# Changelog | |||
|
|||
## 0.13.3 (TBD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that your forked main
branch is 33 commits behind the main
in our repo.
We are now working on 0.14.0
and you'll see the entries in the Changelog once you sync your branch with the main repo.
@@ -384,6 +384,10 @@ The `send` method accepts an object with the following fields: | |||
|
|||
The email address of the sender. | |||
|
|||
- `replyTo?: string` | |||
|
|||
The email address to which the recipient can reply to. Only available for SendGrid provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you analyze the other providers to see if they also provide options for replyTo
field? We need to consider the SMTP and the Mailgun providers to make sure Wasp works for as many people as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only checked the Mailgun provider which does not offer a reply_to
option. I'm pretty sure, that it can be implemented for the SMTP provider as well. I will have a look at it.
@@ -4,7 +4,7 @@ import type { SendGridProvider, EmailSender } from "../types"; | |||
|
|||
// PRIVATE API | |||
export function initSendGridEmailSender( | |||
provider: SendGridProvider | |||
provider: SendGridProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this indent change to keep the changeset minimal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, formatters at work I guess.
Nice job! Thanks for the contribution. There are couple of things we need to do before we can merge this:
|
Closed by accident! |
Description
This PR introduces the following changes:
Add optional replyTo field to Email type (commit 7ddc034): This commit adds a new optional field replyTo to the Email type. This allows for specifying a different email address that recipients will reply to.
Add optional replyTo field to SendGrid provider (commit adae95b): This commit extends the SendGrid provider to support the new replyTo field. If provided, the SendGrid provider will use this field as the reply-to address in the emails it sends.
Document replyTo field for SendGrid provider (commit 1120fae): This commit adds documentation for the new replyTo field in the SendGrid provider. This helps to ensure that the usage of this new field is clear to other developers.
These changes provide more flexibility in handling replies to emails sent by the application since without the replyTo field set, replying to an E-Mail sent by SendGrid will result in a
550 Mailbox not found
.Select what type of change this PR introduces:
Update Waspc ChangeLog and version if needed
If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following: