Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😃🚀📝 #1798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

😃🚀📝 #1798

wants to merge 1 commit into from

Conversation

Martinsos
Copy link
Member

No description provided.

@Martinsos Martinsos marked this pull request as ready for review February 22, 2024 13:59
infomiho
infomiho reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@infomiho infomiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the firm rule made sense since it made easier to think about whether to use emojis.

I challenge the change by asking for examples where the emojis are used in some of the most popular framework's docs.

@Martinsos
Copy link
Member Author

One quick example I encountered, actually the same as the usage I tried to do in the migration docs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infomiho infomiho infomiho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martinsos @infomiho