Fix CropTransformation for use case with width = 0 and height = 0 #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Glide documentation says, Transformations are meant to be statless.
The
transform
method instead changes the propertieswidth
andheight
in the very first lines: each property is immutable only if its initial
value is not zero.
Moreover the bitmap
toTransform
is the original bitmap, so you shouldnot use its size as the desired size of the resulting bitmap; you have
to use the parameters
outWidth
andoutHeight
, instead.