Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CropTransformation for use case with width = 0 and height = 0 #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dscoppelletti
Copy link

As Glide documentation says, Transformations are meant to be statless.
The transform method instead changes the properties width and height
in the very first lines: each property is immutable only if its initial
value is not zero.
Moreover the bitmap toTransform is the original bitmap, so you should
not use its size as the desired size of the resulting bitmap; you have
to use the parameters outWidth and outHeight, instead.

As Glide documentation says, Transformations are meant to be statless.
The transform method instead changes the properties width and height
in the very first lines: each property is immutable only if its initial
value is not zero.
Moreover the bitmap toTransform is the original bitmap, so you should
not use its size as the desired size of the resulting bitmap; you have
to use the parameters outWidth and outHeight, instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant