fix: narrow bare excepts around json.loads in python_executor - #95
Open
harshadkhetpal wants to merge 1 commit into
Open
fix: narrow bare excepts around json.loads in python_executor#95harshadkhetpal wants to merge 1 commit into
harshadkhetpal wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Harshad Khetpal <harshadkhetpal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bare
except:clauses inLightAgent/builtin_tools/python_executor.pywrapjson.loadsfallbacks (ruff E722). A bare except also swallowsKeyboardInterrupt/SystemExitand can mask unrelated bugs in the recursive code-cleaning path. Narrowed both to the exceptionsjson.loadsactually raises:Behavior for malformed JSON input is unchanged — only the accidental swallowing of process-control exceptions is removed.
Testing
python -m py_compilepasses;ruff check --select E722on the file goes from 2 errors to clean.🤖 Generated with Claude Code