-
Notifications
You must be signed in to change notification settings - Fork 169
Support for minimum and maximum dates #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anderconal
wants to merge
9
commits into
wangzuo:master
Choose a base branch
from
anderconal:enhancement/min-max-date
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow no minDate prop Allow no maxDate prop Allow no minDate & no maxDate props Change the way we calculate disabled days (using isBefore and isAfter instead of isBetween)
Start of month as date if nextMonth clicked & moment is after maxDate End of month as date if prevMonth clicked & moment is before minDate
Set current time each time same date on next or prev month is not between minDate & maxDate
|
Are there any plans to merge this in? It's been 4 months since this PR was opened. |
|
@wangzuo @anderconal Can this merge? It would be a very nice to have 👍 |
Author
|
@sandragajowski I can't merge it, @wangzuo is the one who should if everything is fine |
|
@wangzuo can we merge it ? It's a really great feature to have |
|
@wangzuo can you merge this? |
|
Hey @wangzuo can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new on this PR?
minDateforInputMomentcomponent.maxDateforInputMomentcomponent.minDateandmaxDate.minDateandmaxDate.CSSupdates in order to applydisabledstyles.Graycolor range updated atvariables.lesswith two previously used gray colors.minDateandmaxDateprops.README.mdupdated with example usingminDate&maxDate.rendersnapshot test updated in order to make it work with the new changes.Screenshots
Previous month button disabled + previous dates disabled + after dates disabled
Next month button disabled + after dates disabled
How to test?
minDateandmaxDatemoments) play with theinputtrying to:Related issue
min and max dates