Alterando o type do erro do Axios no StormGlass client

package.json

@@ -13,7 +13,7 @@
     "test:functional": "dotenv -e .env -- jest --projects ./test --runInBand",
     "test:unit": "dotenv -e .env -- jest",
     "style:check": "prettier --check src/**/*.ts test/**/*.ts",
-    "style:fix": "prettier --write src/**/*.ts' test/**/*.ts"
+    "style:fix": "prettier --write src/**/*.ts test/**/*.ts"
   },
   "engines": {
     "node": "14"

src/clients/__test__/stormGlass.test.ts

@@ -78,31 +78,41 @@ describe('StormGlass client', () => {
     const lat = -33.792726;
     const lng = 151.289824;
 
-    mockedRequest.get.mockRejectedValue({ message: 'Network Error' });
+    mockedRequest.get.mockRejectedValue('Network Error');
 
     MockedCacheUtil.get.mockReturnValue(undefined);
 
     const stormGlass = new StormGlass(mockedRequest, MockedCacheUtil);
 
     await expect(stormGlass.fetchPoints(lat, lng)).rejects.toThrow(
-      'Unexpected error when trying to communicate to StormGlass: Network Error'
+      'Unexpected error when trying to communicate to StormGlass: "Network Error"'
     );
   });
 
   it('should get an StormGlassResponseError when the StormGlass service responds with error', async () => {
     const lat = -33.792726;
     const lng = 151.289824;
 
-    mockedRequest.get.mockRejectedValue({
-      response: {
+    class FakeAxiosError extends Error {
+      constructor(public response: object) {
+        super();
+      }
+    }
+
+    mockedRequest.get.mockRejectedValue(
+      new FakeAxiosError({
         status: 429,
         data: { errors: ['Rate Limit reached'] },
-      },
-    });
+      })
+    );
     /**
      * Mock static function return
      */
     MockedRequestClass.isRequestError.mockReturnValue(true);
+    MockedRequestClass.extractErrorData.mockReturnValue({
+      status: 429,
+      data: { errors: ['Rate Limit reached'] },
+    });
 
     MockedCacheUtil.get.mockReturnValue(undefined);
 

src/clients/stormGlass.ts

@@ -115,18 +115,17 @@ export class StormGlass {
         }
       );
       return this.normalizeResponse(response.data);
-    } catch (err) {
-      /**
-       * This is handling the Axios errors specifically
-       */
-      if (HTTPUtil.Request.isRequestError(err)) {
+    } catch (err: unknown) {
+      if (err instanceof Error && HTTPUtil.Request.isRequestError(err)) {
+        const error = HTTPUtil.Request.extractErrorData(err);
         throw new StormGlassResponseError(
-          `Error: ${JSON.stringify(err.response.data)} Code: ${
-            err.response.status
-          }`
+          `Error: ${JSON.stringify(error.data)} Code: ${error.status}`
         );
       }
-      throw new ClientRequestError(err.message);
+      /**
+       * All the other errors will fallback to a generic client error
+       */
+      throw new ClientRequestError(JSON.stringify(err));
     }
   }
 

src/util/request.ts

@@ -12,7 +12,22 @@ export class Request {
     return this.request.get<T, Response<T>>(url, config);
   }
 
-  public static isRequestError(error: AxiosError): boolean {
-    return !!(error.response && error.response.status);
+  public static isRequestError(error: Error): boolean {
+    return !!(
+      (error as AxiosError).response && (error as AxiosError).response?.status
+    );
+  }
+
+  public static extractErrorData(
+    error: unknown
+  ): Pick<AxiosResponse, 'data' | 'status'> {
+    const axiosError = error as AxiosError;
+    if (axiosError.response && axiosError.response.status) {
+      return {
+        data: axiosError.response.data,
+        status: axiosError.response.status,
+      };
+    }
+    throw Error(`The error ${error} is not a Request Error`);
   }
 }