Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alterando o try catch do getForecastPointsFromApi #78

Closed
wants to merge 1 commit into from
Closed

alterando o try catch do getForecastPointsFromApi #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/clients/stormGlass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import * as HTTPUtil from '@src/util/request';
import { TimeUtil } from '@src/util/time';
import CacheUtil from '@src/util/cache';
import logger from '@src/logger';
import { AxiosError } from 'axios';

export interface StormGlassPointSource {
[key: string]: number;
Expand Down Expand Up @@ -115,18 +116,20 @@ export class StormGlass {
}
);
return this.normalizeResponse(response.data);
} catch (err) {
} catch (err: unknown) {
/**
* This is handling the Axios errors specifically
*/
if (HTTPUtil.Request.isRequestError(err)) {
const axiosError = err as AxiosError;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cara tua lógica está certa, mas como sei que tu também esta buscando entender a forma que eu faria eu abri outro pull request mostrando como eu fiz #79.
A principal diferença é que aqui no teu tu ta importando o AxiosError na classe StormGlass e isso faz com que o Axios seja exposto para a aplicação, no curso a gente encapsula toda a lógica de requisição dentro da classe Request, dessa maneira se mudarmos do Axios para outra biblioteca não precisaremos alterar o resto da aplicação.

Quanto menos o resto da aplicação souber das bibliotecas externas melhor :D

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah beleza, consegui entender melhor agora o porquê de utilizar a encapsulação e também a reutilização de código caso seja necessário alterar o Axios para outra lib.
Tranquilo então @waldemarnt, obrigado pela explicação ;D

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leoander01 Valeu pela contribuição! Ja atualizei todo o código e todos os passos 💯

const errorMessage = err as Error;
if (axiosError.response && axiosError.response.data) {
throw new StormGlassResponseError(
`Error: ${JSON.stringify(err.response.data)} Code: ${
err.response.status
`Error: ${JSON.stringify(axiosError.response.data)} Code: ${
axiosError.response.status
}`
);
}
throw new ClientRequestError(err.message);
throw new ClientRequestError(errorMessage.message);
}
}

Expand Down