Make lexers auto-register themselves #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandarez
force-pushed
the
feature/init-lexers
branch
2 times, most recently
from
d95aa0e to
ecf66d0
Compare
alanhamlett
approved these changes
Sep 24, 2023
gandarez
force-pushed
the
feature/init-lexers
branch
3 times, most recently
from
e38e845 to
9785625
Compare
gandarez
force-pushed
the
feature/init-lexers
branch
from
9785625 to
7058206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies how lexers are initialized by replacing the
Lexer interfacebyinit func. This approach solves the problem of forgetting to add the lexer to lexers array and would never get loaded.