Fix finding location of wakatime-cli on Windows #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homebrew macOS Intel: /usr/local/bin macOS ARM: /opt/homebrew/bin Linux: /home/linuxbrew/.linuxbrew/bin or: ~/.linuxbrew/bin
alanhamlett
reviewed
Dec 25, 2021
| @@ -126,13 +126,13 @@ let s:VERSION = '9.0.1' | |||
| let path = path . '.exe' | |||
| endif | |||
|
|
|||
| " Check for wakatime-cli installed via Homebrew | |||
There was a problem hiding this comment.
We still need this for Mac users.
There was a problem hiding this comment.
If the user config is correct, there should be no problem.
If we are worried about failure, we should set these paths:
Homebrew
macOS Intel: /usr/local/bin
macOS ARM: /opt/homebrew/bin
Linux: /home/linuxbrew/.linuxbrew/bin
or: ~/.linuxbrew/bin
alanhamlett
reviewed
Dec 25, 2021
alanhamlett
reviewed
Dec 25, 2021
alanhamlett
approved these changes
Dec 25, 2021
|
Thank you! |
alanhamlett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #116